vishesh92 commented on code in PR #203:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/203#discussion_r2302984116


##########
cloudstack/resource_cloudstack_network_acl_rule.go:
##########
@@ -198,6 +209,11 @@ func createNetworkACLRule(d *schema.ResourceData, meta 
interface{}, rule map[str
        // Create a new parameter struct
        p := cs.NetworkACL.NewCreateNetworkACLParams(rule["protocol"].(string))
 
+       // If a rule ID is specified, set it
+       if ruleId, ok := rule["rule_number"].(int); ok && ruleId > 0 {
+               p.SetNumber(ruleId)
+       }

Review Comment:
   ```suggestion
        if ruleNum, ok := rule["rule_number"].(int); ok && ruleNum > 0 {
                p.SetNumber(ruleNum)
        }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to