vishesh92 commented on code in PR #205:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/205#discussion_r2307073042


##########
cloudstack/resource_cloudstack_network_offering.go:
##########
@@ -50,6 +50,85 @@ func resourceCloudStackNetworkOffering() *schema.Resource {
                                Type:     schema.TypeString,
                                Required: true,
                        },
+                       "domain_id": {
+                               Type: schema.TypeList,
+                               Elem: &schema.Schema{
+                                       Type: schema.TypeString,
+                               },
+                               Optional:    true,
+                               Description: "the ID of the containing 
domain(s), null for public offerings",
+                       },
+                       "network_rate": {

Review Comment:
   Need to add ForceNew:    true, for all these options to ensure new network 
offering is created. As of now, if I create an offering and then change the 
network_rate, I see the plugin crashing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to