shwstppr commented on code in PR #562:
URL:
https://github.com/apache/cloudstack-documentation/pull/562#discussion_r2343306493
##########
source/adminguide/virtual_machines/importing_unmanaging_vms.rst:
##########
@@ -362,6 +362,22 @@ Preserving unmanaged Instance NICs
The zone setting: unmanage.vm.preserve.nics can be used to preserve Instance
NICs and its MAC addresses after unmanaging them. If set to true, the Instance
NICs (and their MAC addresses) are preserved when unmanaging it. Otherwise,
NICs are removed and MAC addresses can be reassigned.
+KVM Specific: Persistent Domain XML when unmanaging Instances
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Review Comment:
```suggestion
Persistent KVM Domain XML for Unmanaged Instances
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
##########
source/adminguide/virtual_machines/importing_unmanaging_vms.rst:
##########
@@ -362,6 +362,22 @@ Preserving unmanaged Instance NICs
The zone setting: unmanage.vm.preserve.nics can be used to preserve Instance
NICs and its MAC addresses after unmanaging them. If set to true, the Instance
NICs (and their MAC addresses) are preserved when unmanaging it. Otherwise,
NICs are removed and MAC addresses can be reassigned.
+KVM Specific: Persistent Domain XML when unmanaging Instances
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Since 4.22, domain XML will be made persistent when Instance is unmanaged from
CloudStack. This will allow to manage the Instance outside of CloudStack using
virsh or other libvirt tools. The domain XML will be stored in directory
/etc/libvirt/qemu.
Review Comment:
```suggestion
Since 4.22, the domain XML of an Instance is made persistent when it is
unmanaged from CloudStack. This allows the Instance to be managed directly
outside of CloudStack using `virsh` or other libvirt tools. The domain XML will
be stored in the directory `/etc/libvirt/qemu` on the relevant KVM host.
```
##########
source/adminguide/virtual_machines/importing_unmanaging_vms.rst:
##########
@@ -362,6 +362,22 @@ Preserving unmanaged Instance NICs
The zone setting: unmanage.vm.preserve.nics can be used to preserve Instance
NICs and its MAC addresses after unmanaging them. If set to true, the Instance
NICs (and their MAC addresses) are preserved when unmanaging it. Otherwise,
NICs are removed and MAC addresses can be reassigned.
+KVM Specific: Persistent Domain XML when unmanaging Instances
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Since 4.22, domain XML will be made persistent when Instance is unmanaged from
CloudStack. This will allow to manage the Instance outside of CloudStack using
virsh or other libvirt tools. The domain XML will be stored in directory
/etc/libvirt/qemu.
+
+Domain XML is taken from Instance but varies based on their state:
+
+- Running Instance
+ - Domain XML is contructed from the Instance and persisted on the Host
where the Instance is running
+- Stopped Instance
+ - Domain XML is constructed from the Instance details available in
CloudStack database
+ - Domain XML will pe persisted on the last host where the Instance was
running before stopping it
Review Comment:
```suggestion
- The domain XML is reconstructed from the Instance details available in
the CloudStack database.
- The reconstructed domain XML is persisted on the last host where the
Instance was running before it was stopped.
```
##########
source/adminguide/virtual_machines/importing_unmanaging_vms.rst:
##########
@@ -362,6 +362,22 @@ Preserving unmanaged Instance NICs
The zone setting: unmanage.vm.preserve.nics can be used to preserve Instance
NICs and its MAC addresses after unmanaging them. If set to true, the Instance
NICs (and their MAC addresses) are preserved when unmanaging it. Otherwise,
NICs are removed and MAC addresses can be reassigned.
+KVM Specific: Persistent Domain XML when unmanaging Instances
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Since 4.22, domain XML will be made persistent when Instance is unmanaged from
CloudStack. This will allow to manage the Instance outside of CloudStack using
virsh or other libvirt tools. The domain XML will be stored in directory
/etc/libvirt/qemu.
+
+Domain XML is taken from Instance but varies based on their state:
+
+- Running Instance
+ - Domain XML is contructed from the Instance and persisted on the Host
where the Instance is running
+- Stopped Instance
+ - Domain XML is constructed from the Instance details available in
CloudStack database
+ - Domain XML will pe persisted on the last host where the Instance was
running before stopping it
+
+.. note:: We recommend Unmanaging Instance in Running state to preserve the
exact domain XML. There is potential to loose some information when unmanaging
in Stopped state.
Review Comment:
```suggestion
.. note::
It is recommended to unmanage Instances while they are in the **Running**
state to ensure the exact domain XML is preserved. When unmanaged in the
Stopped state, some information may be lost due to reconstruction.
```
##########
source/adminguide/virtual_machines/importing_unmanaging_vms.rst:
##########
@@ -362,6 +362,22 @@ Preserving unmanaged Instance NICs
The zone setting: unmanage.vm.preserve.nics can be used to preserve Instance
NICs and its MAC addresses after unmanaging them. If set to true, the Instance
NICs (and their MAC addresses) are preserved when unmanaging it. Otherwise,
NICs are removed and MAC addresses can be reassigned.
+KVM Specific: Persistent Domain XML when unmanaging Instances
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Since 4.22, domain XML will be made persistent when Instance is unmanaged from
CloudStack. This will allow to manage the Instance outside of CloudStack using
virsh or other libvirt tools. The domain XML will be stored in directory
/etc/libvirt/qemu.
+
+Domain XML is taken from Instance but varies based on their state:
+
+- Running Instance
+ - Domain XML is contructed from the Instance and persisted on the Host
where the Instance is running
Review Comment:
```suggestion
- The existing domain XML is retrieved from the Instance and persisted on
the host where the Instance is running.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
