Copilot commented on code in PR #83:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/83#discussion_r2560173545
##########
cloudstack.go:
##########
@@ -234,7 +238,14 @@ func (cs *CSCloud) GetZoneByNodeName(ctx context.Context,
nodeName types.NodeNam
klog.V(2).Infof("Current zone is %v", cs.zone)
Review Comment:
The log message is logging `cs.zone` (the configured zone) instead of
`instance.Zonename` (the actual zone of the queried node). This is misleading
because the zone being returned in `zone.FailureDomain` is `instance.Zonename`,
not `cs.zone`. Consider changing to: `klog.V(2).Infof("Current zone is %v",
instance.Zonename)`
##########
cloudstack.go:
##########
@@ -212,7 +216,7 @@ func (cs *CSCloud) GetZoneByProviderID(ctx context.Context,
providerID string) (
klog.V(2).Infof("Current zone is %v", cs.zone)
Review Comment:
The log message is logging `cs.zone` (the configured zone) instead of
`instance.Zonename` (the actual zone of the queried instance). This is
misleading because the zone being returned in `zone.FailureDomain` is
`instance.Zonename`, not `cs.zone`. Consider changing to:
`klog.V(2).Infof("Current zone is %v", instance.Zonename)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
