vishesh92 commented on PR #78: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/78#issuecomment-3581662700
> > Code looks good. But it doesn't handle when the CIDR list is updated in the annotation. > > This is because that API didn't exist when the PR was first created. - [apache/cloudstack#11568](https://github.com/apache/cloudstack/pull/11568) > > Can we merge this as is, and maybe create an issue for the update piece as well as some code refactoring suggestions? I have created a PR here: https://github.com/apache/cloudstack-kubernetes-provider/pull/86 This needs a new cloudstack-go SDK release for it to work for 4.22+ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
