vishesh92 opened a new pull request, #131:
URL: https://github.com/apache/cloudstack-go/pull/131

   Fixes https://github.com/apache/cloudstack-go/issues/104
   
   <details><summary>Details</summary>
   <p>
   
   This pull request updates the way `userdatadetails` are serialized to URL 
parameters across several CloudStack API parameter structs. Instead of using 
fixed `.key` and `.value` fields, the code now dynamically uses the map key as 
the parameter name, improving flexibility and aligning with expected API 
conventions. The code generator is also updated to reflect this change, 
ensuring future code generation remains consistent.
   
   **Parameter serialization changes:**
   
   * Updated all usages of `userdatadetails` in `toURLValues()` methods to 
serialize each key-value pair as `userdatadetails[i].<key>=<value>` instead of 
`userdatadetails[i].key=<key>` and `userdatadetails[i].value=<value>`. This 
affects:
     - `DeployVirtualMachineParams` (`cloudstack/VirtualMachineService.go`)
     - `UpdateVirtualMachineParams` (`cloudstack/VirtualMachineService.go`)
     - `ResetUserDataForVirtualMachineParams` 
(`cloudstack/VirtualMachineService.go`)
     - `DeployVnfApplianceParams` 
(`cloudstack/VirtualNetworkFunctionsService.go`)
     - `CreateAutoScaleVmProfileParams` (`cloudstack/AutoScaleService.go`)
     - `UpdateAutoScaleVmProfileParams` (`cloudstack/AutoScaleService.go`)
   
   **Code generation update:**
   
   * Modified the code generator (`generate/generate.go`) to emit the new 
serialization logic for `userdatadetails`, ensuring future generated code uses 
the correct format.
   
   </p>
   </details> 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to