Copilot commented on code in PR #298:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/298#discussion_r3755470412
##########
cloudstack/resource_cloudstack_egress_firewall.go:
##########
@@ -70,6 +70,13 @@ func resourceCloudStackEgressFirewall() *schema.Resource {
Set:
schema.HashString,
},
+ "dest_cidr_list": {
+ Type:
schema.TypeSet,
+ Optional: true,
+ Elem:
&schema.Schema{Type: schema.TypeString},
+ Set:
schema.HashString,
+ },
Review Comment:
New `dest_cidr_list` support is added to the rule schema and read path, but
there is no acceptance test covering (1) sending `destcidrlist` on
create/update and (2) reading it back into state. Given `rule` is a TypeSet, a
test should assert the presence of the rule using
`TestCheckTypeSetElemNestedAttrs` rather than index-based paths, and verify
`dest_cidr_list` contains the expected CIDR(s).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
