sudo87 commented on issue #296:
URL: 
https://github.com/apache/cloudstack-terraform-provider/issues/296#issuecomment-5312021765

   Reviewed and tested both PRs since there's been no response.
   
   [#265](https://github.com/apache/cloudstack-terraform-provider/pull/265) 
only adds the dest_cidr_list schema field. It's never wired into the create or 
read calls, so it wouldn't actually work.
   
   [#298](https://github.com/apache/cloudstack-terraform-provider/pull/298) 
includes that same schema change plus the missing implementation (sets it on 
create, reads it back correctly), and passes build/vet/fmt plus acceptance 
testing against a local CloudStack simulator, including added coverage for 
dest_cidr_list create/update/remove.
   
   Plan to merge 
[#298](https://github.com/apache/cloudstack-terraform-provider/pull/298) and 
will close 
[#265](https://github.com/apache/cloudstack-terraform-provider/pull/265) as 
superseded. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to