sidshas03 commented on PR #219: URL: https://github.com/apache/cloudstack-terraform-provider/pull/219#issuecomment-5319492229
Hi @sureshanaparti @sudo87 @kiranchavala, sorry for the delay, got held up with some work. Pushed the changes now. Branch was far behind main so there were conflicts, and the L2 acceptance test was failing because it used DefaultSharedNetworkOffering (needs gateway/netmask). Old CustomizeDiff was also guessing type from cidr, which broke the no-cidr isolated network case on main. Merged latest main, L2 test now uses DefaultL2NetworkOffering, CustomizeDiff only validates type/cidr, and Read sets type from the API. Added unit tests for the type/cidr cases. Feature is same, cidr not required for L2. Fixes #214. Please approve the workflow run when you get time, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
