dheeraj12347 commented on PR #335: URL: https://github.com/apache/cloudstack-terraform-provider/pull/335#issuecomment-5495660084
Hi @sudo87 and @DaanHoogland , I’ve added a follow-up contribution in PR #335 for the cloudstack_project display_text migration. I focused on validating the compatibility behavior introduced by the new display_text field: Added acceptance coverage for configurations using display_text. Added coverage for the case where both display_text and deprecated displaytext are configured, verifying that display_text takes precedence. Added update coverage for the effective display-text value. During the full acceptance run, I found an import-state mismatch where Read() populated display_text while an imported resource expected the legacy displaytext representation. Adjusted the Read() state handling to distinguish between legacy configuration, new display_text configuration, and imported resources where neither field is configured. Re-ran the complete cloudstack_project acceptance suite: all 11 tests pass. Also verified make test and git diff --check. The follow-up changes are in commit 37ebc48 on the PR. I’d appreciate your review and any feedback on whether you’d prefer the import compatibility handling or test structure to be adjusted further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
