Copilot commented on code in PR #339:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/339#discussion_r3921418214
##########
cloudstack/resource_cloudstack_network_offering.go:
##########
@@ -316,6 +325,9 @@ func resourceCloudStackNetworkOfferingUpdate(d
*schema.ResourceData, meta interf
// Create a new parameter struct
p := cs.NetworkOffering.NewUpdateNetworkOfferingParams()
+ // Target this network offering
+ p.SetId(d.Id())
+
// Set the new domain id
p.SetDomainid(d.Get("domain_id").(string))
Review Comment:
The domain_id update block sets Domainid, but the subsequent inline comment
/ error message refers to "traffic type", which is misleading when
troubleshooting failures in this update path.
##########
cloudstack/resource_cloudstack_network_offering_test.go:
##########
@@ -0,0 +1,64 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package cloudstack
+
+import (
+ "fmt"
+ "testing"
+
+ "github.com/hashicorp/terraform-plugin-testing/helper/resource"
+)
Review Comment:
This acceptance test will need CloudStack client and terraform state imports
once it adds remote existence / destroy verification (consistent with other
acceptance tests in this repo).
This issue also appears in the following locations of the same file:
- line 30
- line 55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
