Copilot commented on code in PR #105:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/105#discussion_r3949910464
##########
cloudstack_loadbalancer.go:
##########
@@ -61,14 +61,17 @@ const (
type loadBalancer struct {
*cloudstack.CloudStackClient
- name string
- algorithm string
- hostIDs []string
- ipAddr string
- ipAddrID string
- networkID string
- projectID string
- rules map[string]*cloudstack.LoadBalancerRule
+ name string
+ algorithm string
+ hostIDs []string
+ ipAddr string
+ ipAddrID string
+ networkID string
+ projectID string
+ rules map[string]*cloudstack.LoadBalancerRule
+ // duplicateRules tracks rules sharing a name with one in rules.
CloudStack
+ // does not enforce unique rule names, and a name-keyed map holds one
per name.
+ duplicateRules []*cloudstack.LoadBalancerRule
ipAssociatedByController bool
Review Comment:
The `loadBalancer` struct field declaration for `duplicateRules` is not
gofmt-formatted (extra alignment spaces). This will likely fail formatting/lint
checks and makes diffs noisier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
