Copilot commented on code in PR #349:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/349#discussion_r4004969194
##########
cloudstack/resource_cloudstack_disk_test.go:
##########
@@ -246,6 +246,7 @@ resource "cloudstack_disk" "foo" {
attach = false
disk_offering = "Small"
zone = "Sandbox-simulator"
+ expunge = true
Review Comment:
The updated acceptance configurations all set `expunge = true`, so none of
them exercises the new default `false` path introduced here. Please add a case
that leaves `expunge` unset/false and verifies that destroy leaves the volume
available for manual expunging; the existing `CheckDestroy` helper assumes the
volume is already absent, so this likely needs a separate assertion for that
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
