dheeraj12347 commented on PR #225: URL: https://github.com/apache/cloudstack-cloudmonkey/pull/225#issuecomment-5733396870
> @dheeraj12347 thanks for the fix, I've run a quick verification with claude and it seems that it's not addressing the issue fully. can you please check it out. > > ``` > ============================================================ > PR #225 test report > ============================================================ > baseline: main efbb895 > under test: pr225 0f0a7da > > ------------------------------------------------------------ > TEST 1 the reported bug: which API does 'list routers version=' use? > ------------------------------------------------------------ > Expected: listRouters (the API's own version field, per issue #224) > Baseline: listKubernetesSupportedVersions (main, the bug) > Actual: listKubernetesSupportedVersions (PR #225) > Verdict: FAIL > > ------------------------------------------------------------ > TEST 2 does the PR change anything at all? (6886 arguments compared) > ------------------------------------------------------------ > Expected: 1 changed row (only the version argument) > Actual: 0 changed rows > Verdict: FAIL > > ------------------------------------------------------------ > TEST 3 the string the PR compares against "version" > ------------------------------------------------------------ > Expected: version (the literal the PR's == compares with) > Actual: version, (from config/cache.go:198, built with a trailing comma) > Verdict: FAIL > > ------------------------------------------------------------ > TEST 4 option list for 3 routers running 2 distinct versions > ------------------------------------------------------------ > Expected: 2 options (4.22.1.0, 4.21.0.0 — de-duplicated) > Actual: 3 options > 4.22.1.0 (10.0.0.1) > 4.22.1.0 (10.0.0.2) > 4.21.0.0 (10.0.0.3) > Verdict: FAIL > > ============================================================ > SUMMARY: 4 of 4 tests FAIL > ============================================================ > ``` > > I don't think this is blocking 6.6.0, I think we can fix it in 6.7.0, thoughts? Hi @borisstoyanov , thanks for the detailed verification. I’ve updated PR #225 to address the issues you pointed out: * Handle the cached `ResponseKeys` format (`version,`) when identifying the current list API for `version=`. * Ensure `version=` uses the current list API’s `version` response field when available. * Deduplicate version values returned from multiple resources. * Updated the regression tests to cover the cached response-key format and duplicate version values. I’ve also verified the changes locally with `go test ./...`, `go vet ./...`, and `git diff --check`. I’ve pushed the changes to PR #225. Please have another look when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
