dheeraj12347 commented on PR #356:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/356#issuecomment-5968932447

   Hi @Damans227, I’ve opened PR #356 for issue #355: Fix project-scoped VM 
lookup in the port forward resource.
   The fix passes the project from the cloudstack_port_forward resource to 
GetVirtualMachineByID() using cloudstack.WithProject(...), so project-scoped 
VMs can be resolved correctly when using account-level credentials.
   I also added a regression acceptance test covering a project-scoped network, 
VM, port-forward resource, and forwarding rule.
   Local validation:
   - go test ./cloudstack ✅
   - go vet ./... ✅
   - git diff --check ✅
   - Targeted acceptance test was attempted but was blocked by the local 
simulator environment because the expected Sandbox-simulator zone was 
unavailable.
   Would appreciate your review when you have time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to