dheeraj12347 commented on PR #229: URL: https://github.com/apache/cloudstack-cloudmonkey/pull/229#issuecomment-6099453277
> the new map suggestions never show up when you press tab. typing tags gives only "=", and tags= or tags[0].k give nothing, because the new part only runs after the full tags= is typed and none of its suggestions start with tags=. copilot's comment above is right. can we add a test that goes through the normal tab completion with tags= so this gets caught? Thanks for the feedback! I've pushed a follow-up commit, `c79972f`, that moves map-field matching before the argument-prefix check and adds a regression test through the normal `autoCompleter.Do` path using `tags=`. The focused test and full `go test ./...` suite pass locally. Could you please review the updated implementation when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
