----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13062/ -----------------------------------------------------------
(Updated July 30, 2013, 8:44 p.m.) Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen. Changes ------- Fix issues with conditional branches and command permissions. Repository: cloudstack-git Description ------- General clean up + Disable password change on UI when ldap is enabled Diffs (updated) ----- client/WEB-INF/classes/resources/messages.properties 3e775e0 client/tomcatconf/commands.properties.in b275017 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccount.java 01aebce plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java 98c9fcf plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy 27f3dfc plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVOSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapCreateAccountCmdSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy f4d185b plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListAllUsersCmdSpec.groovy 2756e92 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy cf2f9ec plugins/user-authenticators/ldap/test/resources/cloudstack.org.ldif f46a383 ui/dictionary.jsp eec0264 ui/scripts/accounts.js 43b242d ui/scripts/ui-custom/accountsWizard.js 7951553 Diff: https://reviews.apache.org/r/13062/diff/ Testing ------- Unit tests, ran + looked at. Thanks, Ian Duffy
