> On Aug. 1, 2013, 12:06 p.m., Koushik Das wrote: > > The changes look fine but I don't see much value with this as the name can > > be easily identified from the db. I feel the logs are used primarily for > > debugging issues. And one key aspect that is missing currently is the > > correlation of logs. Currently when a API call is made to MS, it traverses > > through various layers in the MS and finally hitting the resource layer and > > then returns back with response. Logs gets generated from each layer but it > > is not very intuitive to relate them to API call. If there is a unique id > > (some kind of uuid) that gets appended to the logs for a specific API call > > then correlation becomes very easy. > > > > I feel adding these kind of correlation would be much more useful.
I disagree on this slightly. Snooping into the db for debugging should be gradually deprecated as a practice. Have you ever needed to look into the xen datastore for finding something? The point is admins map their hostnames to DNS addresses in datacenters and having via: 15 (representation of cloudstack) in the debug log is less intuitive compared to having command via kvm-host-0102. If I see command X failed on the kvm-host-0102 all I'll do as an admin of the cloud would be to inspect kvm-host-0102 over ssh. If you have 14 there I'll go to w3schools.com and start learning SQL :) - Prasanna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13072/#review24435 ----------------------------------------------------------- On July 30, 2013, 5:37 p.m., Marcus Sorensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13072/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 5:37 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-3872 > > > Repository: cloudstack-git > > > Description > ------- > > Print agent name when logging Commands sent to VM hosts. See bug description. > I'm not super familiar with this code, so I'd like someone to look over it > and verify it's the right thing. > > > Diffs > ----- > > core/src/com/cloud/agent/transport/Request.java b0fa4cc > server/src/com/cloud/agent/manager/AgentManagerImpl.java b157838 > > Diff: https://reviews.apache.org/r/13072/diff/ > > > Testing > ------- > > Tested on KVM zone, need help testing others. > > > Thanks, > > Marcus Sorensen > >
