----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24520 -----------------------------------------------------------
I haven't tested the patch, but I'm missing some comments. Can we add clear comments as to WHY this is in the code? Otherwise I'm afraid this will become legacy and in 6 months new committer won't have the slightest idea of why this is in there. - Wido den Hollander On Aug. 2, 2013, 6:39 a.m., Wei Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13223/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2013, 6:39 a.m.) > > > Review request for cloudstack, edison su and Wido den Hollander. > > > Bugs: CLOUDSTACK-2729 > > > Repository: cloudstack-git > > > Description > ------- > > The storage pool issue (CLOUDSTACK-2729) is because of a bug in libvirt > (https://bugzilla.redhat.com/show_bug.cgi?id=977706) > We need to prevent deleting a volume when refreshing the pool. > This patch use a simple file lock to implement it. > > PS: I have tested another file lock similar to Read/Write file lock, but it > was very unstable. > > > Diffs > ----- > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java > dae25ae > > Diff: https://reviews.apache.org/r/13223/diff/ > > > Testing > ------- > > Applied on 4.0.2 and 4.0.1 > > Testing On 4.0.1 From 20,June > 3 nodes, create a VM on each node every 15 minutes. Destroy the VMs 5 minutes > later. expunge.inteval = 600 (10 minutes), expunge.worker = 2 > > > Testing On 4.0.2 From 01,July > 2 nodes, create two VMs on each node every 5 minutes. Destroy the VMs 4 > minutes later. expunge.inteval = 600 (10 minutes), expunge.worker = 2 > > > Thanks, > > Wei Zhou > >
