----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13365/#review24773 -----------------------------------------------------------
Ship it! Ship It! - Rajesh Battala On Aug. 6, 2013, 10:53 p.m., Marcus Sorensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13365/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2013, 10:53 p.m.) > > > Review request for cloudstack and Rajesh Battala. > > > Bugs: CLOUDSTACK-4121 > > > Repository: cloudstack-git > > > Description > ------- > > See CLOUDSTACK-4121. This seems to allow the hypervisor type to be queried > for local volumes, by using the cluster level storage SQL query. I *think* > these three are the only storage-related scope types. > > You may want to tweak this a bit more to not bother with the sql statement if > sql=null, but I think it provides a pretty obvious heads-up as to what's > wrong, aside from my little error message. > > > Diffs > ----- > > engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java 273f7f9 > > Diff: https://reviews.apache.org/r/13365/diff/ > > > Testing > ------- > > tested in KVM fresh 4.2 zone, VMs now starting rather than throwing SQL > errors. > > > Thanks, > > Marcus Sorensen > >
