----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13424/#review24964 -----------------------------------------------------------
Changes look good to me. But the upgrade path has changed to accommodate upgrades from 4.1.1 and 4.1.2. Patch doesn't apply on the latest code due to this change. Please submit the patch again. - Kishan Kavala On Aug. 9, 2013, 5:20 p.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13424/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2013, 5:20 p.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Bugs: CLOUDSTACK-4123 and CLOUDSTACK-4205 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the > Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2 > > Updating the new system template URLs for the existing templates during > upgrade to 4.2. > If new 4.2 system template is registered before upgrade then marking the > old templates as removed during upgrade. > > CLOUDSTACK-4205: System VMs are not booting up with new templates after > Upgrade from 3.0.6 to 4.2. > > > Diffs > ----- > > engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9243225 > engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 0941408 > server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java a583954 > server/src/com/cloud/resource/ResourceManagerImpl.java e5441af > server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java > 17cbf5c > > Diff: https://reviews.apache.org/r/13424/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > >
