----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13441/#review24968 -----------------------------------------------------------
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java <https://reviews.apache.org/r/13441/#comment49132> CPU weight computation is not considering the number of CPUs in the VM but utilization is considering it. Shouldn't both follow the same logic? If not can you explain the logic and put a comment in the code for the same. Also what is logic for multiplying the speed with 0.99? - Koushik Das On Aug. 9, 2013, 1 p.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13441/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2013, 1 p.m.) > > > Review request for cloudstack and Koushik Das. > > > Bugs: CLOUDSTACK-3850 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-3850: CPU cap should be per VM not per VCPU > > > Diffs > ----- > > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > e100211 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java > d230be1 > > Diff: https://reviews.apache.org/r/13441/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > >
