----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13680/#review25340 -----------------------------------------------------------
test/integration/component/test_netscaler_lb.py <https://reviews.apache.org/r/13680/#comment49726> Since you have multiple test suites trying to add the same netscaler device, it will be good to keep this whole creation stuff in try block so that even if something fails then you will have your tearDown called. something like I mentioned here : try: add_netscaler() NetworkOffering.create() ServiceOffering.create() except: call tearDownClass() If we do it in the above way then if something goes wrong in network offering creation then our except block will still call the tearDown for removing netscaler device so that your rest of test suites will not fail during netscaler device addition. tools/marvin/marvin/integration/lib/common.py <https://reviews.apache.org/r/13680/#comment49725> IMO, we don't have to go for an additional library call for add_netscaler rather we can rely just on Netscaler.add in base.py. few reasons for saying this is as mentioned below. 1. Usually the automation environment is prepared out of a .cfg file where we can add the following to make a provider configured and enabled by default using something like below "providers": [ { "broadcastdomainrange": "ZONE", "name": "Netscaler" } ] - venkata swamy babu budumuru On Aug. 20, 2013, 6:18 a.m., Sowmya Krishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13680/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2013, 6:18 a.m.) > > > Review request for cloudstack, venkata swamy babu budumuru and Prasanna > Santhanam. > > > Bugs: CLOUDSTACK-3927 and CLOUDSTACK-3928 > > > Repository: cloudstack-git > > > Description > ------- > > Fix to add NS device in setupClass and remove in tearDown > Added a common method to perform these in common.add_netscaler() > Also fixes few account object issues in netscaler_configs. > > Patch will help in keeping each test suite independent. Otherwise we cannot > identify which NS an LB rule will be deployed in if there's more than one NS > device. > > > Diffs > ----- > > test/integration/component/test_netscaler_configs.py bcea254 > test/integration/component/test_netscaler_lb.py 3942f94 > test/integration/component/test_netscaler_lb_algo.py 477bd69 > test/integration/component/test_netscaler_lb_sticky.py 1edfd7b > tools/marvin/marvin/integration/lib/common.py 4f5acef > > Diff: https://reviews.apache.org/r/13680/diff/ > > > Testing > ------- > > Tested locallly > > > Thanks, > > Sowmya Krishnan > >
