----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12545/#review25616 -----------------------------------------------------------
Hi Girish Shilamkar, Apologies for late review. Some changes needs to be taken care of. 1) I think we do not have service like "SSHKey" to get the sshkey enabled template. We need to create a vm, put the ssh/password scripts accordingly in the VM, create template from that VM and then use this template for our tests. You can refer to marvin test in test_vm_passwdenabled.py 2) We have 10 tests in this file and each test tries to create separate account, networks, router vms and guest vms. Could you please try clubbing the resources in the tests that use common resources. - Harikrishna Patnala On Aug. 13, 2013, 7:41 a.m., Girish Shilamkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12545/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2013, 7:41 a.m.) > > > Review request for cloudstack, Harikrishna Patnala and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-1800 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM > > > Diffs > ----- > > test/integration/component/test_reset_ssh_keypair.py PRE-CREATION > > Diff: https://reviews.apache.org/r/12545/diff/ > > > Testing > ------- > > > Thanks, > > Girish Shilamkar > >
