I want to apply this now, any objections?
On Wed, Sep 18, 2013 at 3:45 PM, daan Hoogland <daan.hoogl...@gmail.com>wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13934/ > Review request for cloudstack, Chiradeep Vittal, Hugo Trippaers, and > Sheng Yang. > By daan Hoogland. > > *Updated Sept. 18, 2013, 1:45 p.m.* > Changes > > tested with regular and bridged networks > > *Bugs: * 4347 > *Repository: * cloudstack-git > Description > > provisioning of a nicira based vpc router > > Testing > > This is a rebase/port of code that has been tested intensively. It is here > for review only at this time. re-tests are needed. > > Diffs (updated) > > - api/src/com/cloud/agent/api/to/IpAddressTO.java (82c7d99) > - api/src/com/cloud/agent/api/to/NetworkTO.java (3edd4c0) > - api/src/com/cloud/network/NetworkService.java (87fecb0) > - api/src/com/cloud/network/Networks.java (f8166c6) > - api/src/com/cloud/network/vpc/PrivateIp.java (eb68433) > - api/src/com/cloud/network/vpc/StaticRouteProfile.java (54aa6e4) > - api/src/com/cloud/network/vpc/VpcGateway.java (9652b4b) > - api/src/com/cloud/network/vpc/VpcService.java (f772879) > - > api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java > (be7e784) > - api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java > (c5c7df5) > - api/test/com/cloud/network/NetworksTest.java (07b55d2) > - > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java > (1fb86e0) > - engine/schema/src/com/cloud/network/dao/NetworkDao.java (d0a1a25) > - engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java (0f83815) > - engine/schema/src/com/cloud/network/vpc/VpcGatewayVO.java (2c592cd) > - engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java > (eb987ea) > - > plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetaNetworkGuru.java > (56bbb28) > - > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java > (c94856d) > - > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > (203587a) > - > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java > (119f117) > - plugins/hypervisors/ovm/src/com/cloud/ovm/hypervisor/OvmResourceBase.java > (8f21c13) > - > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > (2253586) > - > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > (3cc60db) > - > plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java > (daf65a1) > - > plugins/network-elements/cisco-vnmc/src/com/cloud/network/element/CiscoVnmcElement.java > (c053856) > - > plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java > (ffddd30) > - > plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java > (46ef332) > - > plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java > (58541c6) > - > plugins/network-elements/nicira-nvp/src/com/cloud/network/element/NiciraNvpElement.java > (686f79c) > - > plugins/network-elements/nicira-nvp/src/com/cloud/network/guru/NiciraNvpGuestNetworkGuru.java > (fc1ecd0) > - > plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java > (e8ff1a0) > - server/src/com/cloud/api/ApiResponseHelper.java (1ad0eab) > - server/src/com/cloud/configuration/ConfigurationManagerImpl.java > (17ef6bf) > - server/src/com/cloud/network/ExternalDeviceUsageManagerImpl.java > (3db5111) > - server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java > (e4625a4) > - server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java > (b86f4ae) > - server/src/com/cloud/network/NetworkServiceImpl.java (eb63fe0) > - server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java > (67ebef1) > - server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java > (55a33cc) > - server/src/com/cloud/network/guru/GuestNetworkGuru.java (e90b84b) > - server/src/com/cloud/network/guru/PrivateNetworkGuru.java (12dce85) > - > server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java > (566f1e4) > - server/src/com/cloud/network/vpc/PrivateGatewayProfile.java (74ce002) > - server/src/com/cloud/network/vpc/PrivateIpAddress.java (2f3cf53) > - server/src/com/cloud/network/vpc/VpcManagerImpl.java (6cace7e) > - server/test/com/cloud/network/CreatePrivateNetworkTest.java (ed9efd6) > - server/test/com/cloud/vpc/MockNetworkManagerImpl.java (003b774) > - server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java (ec1a017) > - utils/src/com/cloud/utils/net/NetUtils.java (7a89103) > > View Diff <https://reviews.apache.org/r/13934/diff/> >