Pedro, Thanks for posting this!
Here's the process that we'll need to follow: I'm going to call a vote to accept this donation to the project on this list. Concurrent with that, we need the appropriate legal representatives from Juniper to complete the Software Grant contract for the donation [1]. I'll follow up on this directly with you, cc'ing the PMC private ML so that any legal work is done on that thread. Once we have the legal doc in hand, and the project voted to accept the donation, I have a brief (3 day) notice period to the incubator project that I'll have to handle. As I've stated previously, I believe that we should take discussion of the technical aspects of this contribution into a discussion of when / if to merge into master *after* we have accepted the donation. Expect to see the VOTE and legal discussion threads start in a few minutes. [1] http://www.apache.org/licenses/software-grant.txt On Tue, Sep 24, 2013 at 11:38:07PM +0000, Pedro Marques wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14325/ > ----------------------------------------------------------- > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > Plugin for contrail virtual network controller. > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Contrail+network+plugin > > > Diffs > ----- > > api/src/com/cloud/network/Network.java 49f380b > client/pom.xml 119c96e > client/tomcatconf/applicationContext.xml.in 9b6636a > client/tomcatconf/commands.properties.in 58c770d > client/tomcatconf/componentContext.xml.in 315c95b > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > 6b81c25 > plugins/network-elements/juniper-contrail/pom.xml PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/command/CreateServiceInstanceCmd.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/response/ServiceInstanceResponse.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElement.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElementImpl.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailGuru.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManager.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManagerImpl.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/DBSyncGeneric.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/EventUtils.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ManagementNetworkGuru.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ModelDatabase.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSync.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSyncImpl.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandler.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandlerImpl.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManager.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManagerImpl.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceVirtualMachine.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpModel.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpPoolModel.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/InstanceIpModel.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelController.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObject.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObjectBase.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ServiceInstanceModel.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VMInterfaceModel.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualMachineModel.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualNetworkModel.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/MockAccountManager.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/NetworkProviderTest.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestConfiguration.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestDbSetup.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/VirtualNetworkModelTest.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/test/resources/contrail.properties > PRE-CREATION > plugins/network-elements/juniper-contrail/test/resources/db.properties > PRE-CREATION > plugins/network-elements/juniper-contrail/test/resources/log4j.properties > PRE-CREATION > plugins/network-elements/juniper-contrail/test/resources/mysql_db_start.sh > PRE-CREATION > plugins/network-elements/juniper-contrail/test/resources/mysql_db_stop.sh > PRE-CREATION > plugins/network-elements/juniper-contrail/test/resources/serviceContext.xml > PRE-CREATION > plugins/pom.xml 0812642 > > Diff: https://reviews.apache.org/r/14325/diff/ > > > Testing > ------- > > Patch includes integration test that verifies that the plugin reacts > correctly to the API for network create and delete and VM instantiation. We > also run automated tests against a setup with one cloudstack management > server and two Xen compute hosts. > > > Thanks, > > Pedro Marques >