I know how to apply them, i don't want to.
On Wed, Sep 25, 2013 at 5:54 PM, Darren Shepherd < darren.s.sheph...@gmail.com> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14231/ > > On September 25th, 2013, 12:34 p.m. UTC, *daan Hoogland* wrote: > > Ship It! > > On September 25th, 2013, 12:44 p.m. UTC, *daan Hoogland* wrote: > > Darren, this one is simple but next time submit a format created with 'git > format-patch' please!?! I copied the lack of code, because it didn't 'git am' > to the source. > > 9fb0a1a61992f93e2105d9a99d507d48a108b0c7 applied > > yeah, sorry. A lot of patches I have pending aren't made with format-patch. > Will do for future. You just need to do "git apply --index <patch>" to > apply a plain old patch. And then commit > > > - Darren > > On September 19th, 2013, 5:03 p.m. UTC, Darren Shepherd wrote: > Review request for cloudstack, Alex Huang and daan Hoogland. > By Darren Shepherd. > > *Updated Sept. 19, 2013, 5:03 p.m.* > *Repository: * cloudstack-git > Description > > Currently DatabaseUpgradeChecker determines the code version by doing > this.getClass().getPackage().getImplementationVersion(). If it can't find > the version it will eventually just give up and not do the database check. > The problem currently is if it doesn't find the version, it will also check > its parent's class version. The parent is java.lang.Object which will return > the java version (for example 1.6.0_43). It doesn't seem like we would > really want to ever try the JDK version as our code version, so this patch it > to just effectively remove that check. > > > Diffs > > - engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java > (f001bf7) > > View Diff <https://reviews.apache.org/r/14231/diff/> >
