----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14320/#review26420 -----------------------------------------------------------
Not sure if this should be in the API since it is a HAProxy-specific configuration. This wouldn't apply to Netscaler or F5. After all the end user has no idea if he is using HAProxy of Netscaler or F5. Likely this flag is of interest to the cloud operator only, so why not put it in zone-wide config instead of the network offering. Do you really see someone creating 2 offerings: one with HttpClose and one without HttpClose? - Chiradeep Vittal On Sept. 26, 2013, 7:01 p.m., daan Hoogland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14320/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2013, 7:01 p.m.) > > > Review request for cloudstack and Wei Zhou. > > > Bugs: CLOUDSTACK-4328 > > > Repository: cloudstack-git > > > Description > ------- > > add boolean option httpModeEnabled to the service offering for use in haproxy > conf > > > Diffs > ----- > > api/src/com/cloud/offering/NetworkOffering.java 6c5573e > api/src/org/apache/cloudstack/api/ApiConstants.java f85784b > > api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java > bdad904 > > api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java > c9c4c8a > core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java ee29290 > core/src/com/cloud/network/HAProxyConfigurator.java 2309125 > core/test/com/cloud/network/HAProxyConfiguratorTest.java PRE-CREATION > engine/components-api/src/com/cloud/configuration/ConfigurationManager.java > 5e1b9b5 > > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java > 53f64fd > engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java eefdc94 > > plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java > ecd6006 > > plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java > 587ae99 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 8a0f7a6 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > 7c026a4 > server/test/com/cloud/vpc/MockConfigurationManagerImpl.java c9a0480 > > server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java > 1f1fb75 > setup/db/db/schema-420to430.sql 44a884d > > Diff: https://reviews.apache.org/r/14320/diff/ > > > Testing > ------- > > created unit test. > instantiated a network with some loadbalancer rule based on a netoffer with > the option to true/false and maxconnections to a non default value -> checked > haproxy.cfg on the router > > > Thanks, > > daan Hoogland > >
