----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14335/#review26666 -----------------------------------------------------------
Checking LB rules deletion after network gc looks good to me. However validation is missing in the code after listing NetworkAcl rules after gc. netacls = NetworkACL.list(self.apiclient, networkid=self.network_1.id) self.debug("List of NetACLS %s" % netacls) Add validation whether NetworkACL.list is returning empty or not. - sanjeev n On Sept. 25, 2013, 1:34 p.m., Girish Shilamkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14335/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2013, 1:34 p.m.) > > > Review request for cloudstack, Harikrishna Patnala and venkata swamy babu > budumuru. > > > Bugs: CLOUDSTACK-4262 > > > Repository: cloudstack-git > > > Description > ------- > > As per the test plan, after waiting for network gc > LB rules should be cleared. Added that check instead of router > being in stopped state. > > > Diffs > ----- > > test/integration/component/test_vpc_network.py 970a625 > > Diff: https://reviews.apache.org/r/14335/diff/ > > > Testing > ------- > > > Thanks, > > Girish Shilamkar > >