----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14248/#review26667 -----------------------------------------------------------
Ship it! Looks good to me. - sanjeev n On Oct. 3, 2013, 7:28 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14248/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2013, 7:28 a.m.) > > > Review request for cloudstack, Harikrishna Patnala, Rayees Namathponnan, > venkata swamy babu budumuru, and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Fixed Test case test_vpc_vm_life_cycle.py: TestVMLifeCycleSharedNwVPC failed > with Insufficient address capacity error > > Changes: > 1) Shared network requires start ip and end ip shile creating it, if you want > to deploy vm in it. Else it throws Insufficient address capacity error > 2) Removed addition of multiple vms in load balancing rule (VMs belonging to > multiple networks). Because this is not allowed. > 3) For test case test_05_destroy_instance_in_network, added wait for cleanup > of vm. So that after it proceeds to check the network rules. > 4) Removed white spaces and unnecessary comments. > > > Diffs > ----- > > test/integration/component/test_vpc_vm_life_cycle.py 9844c1f > > Diff: https://reviews.apache.org/r/14248/diff/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Gaurav Aradhye > >
