----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14489/#review26668 -----------------------------------------------------------
Ship it! Looks good to me. - Rajesh Battala On Oct. 4, 2013, 9:43 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14489/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2013, 9:43 a.m.) > > > Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh > Chodapuneedi. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3994 > > > Repository: cloudstack-git > > > Description > ------- > > returning false when hostPoolRecords size is zero > > > Diffs > ----- > > > plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java > b9b7424 > > Diff: https://reviews.apache.org/r/14489/diff/ > > > Testing > ------- > > tested on my local setup > > > Thanks, > > Anshul Gangwar > >
