-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14549/#review26819
-----------------------------------------------------------
- Is there a reason why no new isolation type was not added for 'contrail
controller'. For other overlay technologies (STT, GRE, VXLAN) that CloudStack
support there is an isolation type and corresponding Guru that handles
isolation type.
- There is a 'EventBus' on to which all events generated by CloudStack gets
published. Right approach would be to plug-in to subscribe to interested events
from event bus. But the current implementation of EventBus expects external
AMQP server, so it may not be ideal. EventInterceptor approach implemented in
the plug-in works fine to get the notification. But enabling it by default in
ApplicationContext does not seem right thing to do.
- If you can add some more details in to the FS on deployment model it will
give more perspective to reviewers
+ is the VRouter mentioned in the FS is a appliance provisioned by
CloudStack for each guest network by servicemanager? Or its a logical router on
the dataplane that does the forwarding?
+ is BGP/MPLS required on the IP fabric and the Hypervisors
- Murali Reddy
On Oct. 8, 2013, 11:58 p.m., Pedro Marques wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14549/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2013, 11:58 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Rename net.juniper.contrail to org.apache.cloudstack.network.contrail.
>
>
> Diffs
> -----
>
> client/tomcatconf/applicationContext.xml.in 0ab2515
> client/tomcatconf/componentContext.xml.in 157ad5a
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/command/CreateServiceInstanceCmd.java
> 92f5eeb
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/api/response/ServiceInstanceResponse.java
> 1b7a7d8
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElement.java
> 885a60f
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailElementImpl.java
> 3a38020
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailGuru.java
> c655b0b
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManager.java
> 5195793
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ContrailManagerImpl.java
> 8a3ca1b
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/DBSyncGeneric.java
> d169b37
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/EventUtils.java
> acd1bed
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ManagementNetworkGuru.java
> bad2502
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ModelDatabase.java
> f9e7c24
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSync.java
> 4c8c2e9
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerDBSyncImpl.java
> 06daf12
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandler.java
> 6f0ecf2
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServerEventHandlerImpl.java
> aa4e9d5
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManager.java
> f3884fb
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceManagerImpl.java
> b90792c
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/management/ServiceVirtualMachine.java
> 9c8b61d
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpModel.java
> ca90666
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/FloatingIpPoolModel.java
> 8e238fd
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/InstanceIpModel.java
> ff08560
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelController.java
> 7abb40a
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObject.java
> 7cd420c
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ModelObjectBase.java
> 4b05e96
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/ServiceInstanceModel.java
> f65bfc7
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VMInterfaceModel.java
> 0ec7c9e
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualMachineModel.java
> df40025
>
> plugins/network-elements/juniper-contrail/src/net/juniper/contrail/model/VirtualNetworkModel.java
> 99ab944
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/response/ServiceInstanceResponse.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElement.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/DBSyncGeneric.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/EventUtils.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSync.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandler.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceVirtualMachine.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpModel.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/FloatingIpPoolModel.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/InstanceIpModel.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelController.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObjectBase.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/MockAccountManager.java
> 029950a
>
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/NetworkProviderTest.java
> c3e07d0
>
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestConfiguration.java
> 87feaa9
>
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/TestDbSetup.java
> 55cef7c
>
> plugins/network-elements/juniper-contrail/test/net/juniper/contrail/management/VirtualNetworkModelTest.java
> a5767c6
>
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestConfiguration.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/TestDbSetup.java
> PRE-CREATION
>
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java
> PRE-CREATION
> plugins/network-elements/juniper-contrail/test/resources/serviceContext.xml
> 623d188
>
> Diff: https://reviews.apache.org/r/14549/diff/
>
>
> Testing
> -------
>
> Integration test passes.
>
>
> Thanks,
>
> Pedro Marques
>
>
