----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14609/#review26990 -----------------------------------------------------------
Ship it! Ship It! - edison su On Oct. 11, 2013, 7:32 p.m., Chris Suich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14609/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2013, 7:32 p.m.) > > > Review request for cloudstack, Darren Shepherd and edison su. > > > Repository: cloudstack-git > > > Description > ------- > > I have added a sorting system for SnapshotStrategies and DataMotionStrategies > to ensure that plugin strategies are asked to handle operations before > hypervisors and the default strategies. > > > Diffs > ----- > > > engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/DataMotionStrategy.java > 6deb6c1 > > engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/SnapshotStrategy.java > 47e595b > > engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriority.java > PRE-CREATION > > engine/api/test/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriorityTest.java > PRE-CREATION > > engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java > fb6962a > > engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/DataMotionServiceImpl.java > 9f0f531 > > engine/storage/integration-test/test/org/apache/cloudstack/storage/test/MockStorageMotionStrategy.java > 6c0bd55 > > engine/storage/integration-test/test/org/apache/cloudstack/storage/test/SnapshotTest.java > f1eed3a > > engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java > aae4cde > > plugins/hypervisors/simulator/src/org/apache/cloudstack/storage/motion/SimulatorDataMotionStrategy.java > 05b3e6b > > plugins/hypervisors/vmware/src/org/apache/cloudstack/storage/motion/VmwareStorageMotionStrategy.java > bdba61b > > plugins/hypervisors/vmware/test/org/apache/cloudstack/storage/motion/VmwareStorageMotionStrategyTest.java > b3ea5d5 > > plugins/hypervisors/xen/src/org/apache/cloudstack/storage/motion/XenServerStorageMotionStrategy.java > c796b69 > server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java 0b53cfd > > Diff: https://reviews.apache.org/r/14609/diff/ > > > Testing > ------- > > I have added appropriate tests for the new code and updated appropriate tests > to handle the new sorting. However, the existing storage tests cannot even be > run. I am working on finding a way to get those tests to work again (a huge > spring dependency issue is causing the problem). > > > Thanks, > > Chris Suich > >
