Rayees: While it doesn't technically break things, it isn't very refined: Here's the output from a machine using a release tarball on a machine without git: ++ git rev-parse HEAD /var/tmp/rpm-tmp.JvKJtB: line 33: git: command not found + echo E.g. when you actually go to release software, the file will be empty.
When you do the same with a release tarball on a machine with git: ++ git rev-parse HEAD fatal: Not a git repository (or any of the parent directories): .git + echo Keep in mind we build a release tarball and it strips out all of the git information. Can we come up with a more refined solution that if the above git rev-parse fails that we also look elsewhere? --David --David On Tue, Oct 22, 2013 at 8:12 PM, Rayees Namathponnan <rayees.namathpon...@citrix.com> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14843/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 12:12 a.m.) > > > Review request for cloudstack, Chip Childers, Frank Zhang, and Hugo Trippaers. > > > Bugs: CLOUDSTACK-1049 > https://issues.apache.org/jira/browse/CLOUDSTACK-1049 > > > Repository: cloudstack-git > > > Description > ------- > > The generation of sccs-info was done by WAF but has been broken from 4.2 > onwords; > > updated cloud.spec file to generate git commit and package with rpm > > if you are building outside git tree, this file will be blank; and packaging > works fine > > > Diffs > ----- > > packaging/centos63/cloud.spec 17fb2b1 > packaging/centos63/cloudstack-sccs PRE-CREATION > > Diff: https://reviews.apache.org/r/14843/diff/ > > > Testing > ------- > > Tested > > > File Attachments (updated) > ---------------- > > We need to merge with 4.2 branch; submitting patch for this > > https://reviews.apache.org/media/uploaded/files/2013/10/23/0001-CLOUDSTACK-1049-git-commit-from-installed-cloudstack.patch > > > Thanks, > > Rayees Namathponnan >
