> On Oct. 28, 2013, 5:55 a.m., Prasanna Santhanam wrote: > > tools/marvin/marvin/marvinPlugin.py, line 148 > > <https://reviews.apache.org/r/14925/diff/1/?file=371276#file371276line148> > > > > Any reason to remove the debug logger? This will cause the write of all > > logs without timestamp and component.
We are already doing it as part of configure method under plugin. Added client_log option as part of options method. - Santhosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14925/#review27589 ----------------------------------------------------------- On Oct. 25, 2013, 10:58 a.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14925/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2013, 10:58 a.m.) > > > Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Added few misc changes. > Deleted some unwanted code. > Few naming convention changes > Added a validateList utility function > > > Diffs > ----- > > tools/marvin/marvin/codes.py 6099d88 > tools/marvin/marvin/configGenerator.py 50614c1 > tools/marvin/marvin/deployDataCenter.py f2dccdb > tools/marvin/marvin/integration/lib/utils.py d81e80d > tools/marvin/marvin/marvinPlugin.py 3b282e4 > > Diff: https://reviews.apache.org/r/14925/diff/ > > > Testing > ------- > > > Thanks, > > Santhosh Edukulla > >
