> On Oct. 29, 2013, 4:35 a.m., Toshiaki Hatano wrote: > > > > Toshiaki Hatano wrote: > Actual issue is not "the physical interface name length must be shorter > than 5" but "generated bridge name cannot exceed 15 character". >
If we check generated bridge name length, users will not face the exception before their cloudstack environment grow up. They will face the exception in production environment suddenly. If we check physical interface name length, users can face the exception whenever bridge name length is not enough. - Yoshikazu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15001/#review27657 ----------------------------------------------------------- On Oct. 29, 2013, 12:51 a.m., Yoshikazu Nojima wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15001/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2013, 12:51 a.m.) > > > Review request for cloudstack, Marcus Sorensen and Toshiaki Hatano. > > > Bugs: CLOUDSTACK-4967 > https://issues.apache.org/jira/browse/CLOUDSTACK-4967 > > > Repository: cloudstack-git > > > Description > ------- > > Guest network isn't created correctly when vxlan is used for isolation > method, VNI is bigger than 10000000, and physical network interface name > length is longer than 4. > This patch fix this issue by raising error when long interface name is > specified. > > Issue remained: document that physical interface name length must be shorter > than 5. > > > Diffs > ----- > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java > f945b74 > > plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/BridgeVifDriverTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/15001/diff/ > > > Testing > ------- > > I confirmed it passes the unit tests I add. > > > Thanks, > > Yoshikazu Nojima > >
