Review Request 15268: Fix for 1125376 NP: Null pointer dereference - make sure the equals implementation is compliant with the contract.

Wed, 06 Nov 2013 07:33:46 -0800 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15268/
-----------------------------------------------------------

Review request for cloudstack and Hugo Trippaers.


Bugs: 1125376, NP:, Null, dereference, and pointer
    https://issues.apache.org/jira/browse/1125376
    https://issues.apache.org/jira/browse/NP:
    https://issues.apache.org/jira/browse/Null
    https://issues.apache.org/jira/browse/dereference
    https://issues.apache.org/jira/browse/pointer


Repository: cloudstack-git


Description
-------

1125376 NP: Null pointer dereference

In 
org.?apache.?cloudstack.?network.?contrail.?model.?ModelObject$ModelReference.?equals(java.?lang.?Object):
 This implementation of equals(Object) violates the contract defined by 
java.lang.Object.equals() because it does not check for null being passed as 
the argument. (From FindBugs™ description) (CWE-476)


Diffs
-----

  
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java
 71d28ac 

Diff: https://reviews.apache.org/r/15268/diff/


Testing
-------


Thanks,

Wilder Rodrigues

Reply via email to