H Min, Your fix will work if you can guarantee that the String passed is a integer. if it has the chance of being in the form of for instance vlan://<some_number> , you should use: vid = Integer.parseInt(BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId)));
regards, Daan On Wed, Nov 6, 2013 at 3:25 AM, Min Chen <min.c...@citrix.com> wrote: > Hi Daan, > > Your commit > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=25c8cee01a450ee924fe108cafe54b046485ab2b > broke Vmware advanced zone setup on Master, where system vm starts failed > with "NumberFormatException", see details in > https://issues.apache.org/jira/browse/CLOUDSTACK-5046. I fixed this blocker > bug (commit 94f9b31c9a4c7ae67feabbe16d2ea753e3183289) by reverting part of > your change on HypervisorHostHelper method, but not sure if there is any > side effect on your another functionality fixed in your commit. Can you > please review to make sure that it is ok? > > Thanks > -min
