----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15243/#review28359 -----------------------------------------------------------
Ship it! Make a version check at the resource layer before firing the reboot command. Can be a incremental change. - Abhinandan Prateek On Nov. 5, 2013, 7:09 p.m., Kishan Kavala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15243/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2013, 7:09 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-4793 > https://issues.apache.org/jira/browse/CLOUDSTACK-4793 > > > Repository: cloudstack-git > > > Description > ------- > > Added UpgradeRouterTemplate API. > Added filters to listRouters API - version/ > accountId/domainId/zoneId/podId/clusterId > listRouters response includes verion and required upgrade flag. > Min VR version is checked before sending commands to router > > > Diffs > ----- > > api/src/com/cloud/network/VirtualNetworkApplianceService.java 58eead2 > api/src/com/cloud/network/router/VirtualRouter.java 9e90e8e > api/src/org/apache/cloudstack/api/ApiConstants.java 3b2bc67 > api/src/org/apache/cloudstack/api/ResponseGenerator.java a8de31d > api/src/org/apache/cloudstack/api/command/admin/router/ListRoutersCmd.java > d7f59b96 > > api/src/org/apache/cloudstack/api/command/admin/router/UpgradeRouterTemplateCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/response/DomainRouterResponse.java > 1d31b58 > > api/src/org/apache/cloudstack/api/response/UpgradeRouterTemplateResponse.java > PRE-CREATION > client/tomcatconf/commands.properties.in 8cbe972 > engine/schema/src/com/cloud/vm/dao/DomainRouterDao.java 95d1ea6 > engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java 7676e2d > server/src/com/cloud/api/ApiResponseHelper.java 769d345 > server/src/com/cloud/api/query/QueryManagerImpl.java f34e60e > server/src/com/cloud/api/query/ViewResponseHelper.java 4051f09 > server/src/com/cloud/api/query/dao/DomainRouterJoinDaoImpl.java 42965bc > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > 9b35a4b > server/src/com/cloud/server/ManagementServerImpl.java 79b20d0 > server/test/com/cloud/vpc/MockVpcVirtualNetworkApplianceManager.java > acdd9dc > utils/src/com/cloud/maint/Version.java 7317547 > > Diff: https://reviews.apache.org/r/15243/diff/ > > > Testing > ------- > > Tested VR upgrade with older and new VR versions. > Tested with various filters. > Verfied that commands are not sent to VR when the min version criteria in not > met > > > Thanks, > > Kishan Kavala > >
