----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15342/ -----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-4648 https://issues.apache.org/jira/browse/CLOUDSTACK-4648 Repository: cloudstack-git Description ------- Fixed following test cases: 1) test_01_volume_from_snapshot 2) test_03_snapshot_detachedDisk 3) test_07_template_from_snapshot All three test cases are running successfully on XenServer but test cases (01 and 07) failing on KVM due to a common issue. Product defect logged for this: https://issues.apache.org/jira/browse/CLOUDSTACK-5097 test_03 is running ok on KVM too, the problem was - disk was not getting detached because it was not unmounted before detaching. Added code to unmount the disk. Diffs ----- test/integration/component/test_snapshots.py 1c2537c tools/marvin/marvin/integration/lib/common.py 164ef20 Diff: https://reviews.apache.org/r/15342/diff/ Testing ------- Log on Xen: test_01_createVM_snapshotTemplate (test_snapshots.TestCreateVMSnapshotTemplate) Test create VM, Snapshot and Template ... ok test_05_snapshot_events (test_snapshots.TestSnapshotEvents) Test snapshot events ... skipped 'Skip' test_01_volume_from_snapshot (test_snapshots.TestSnapshots) Test Creating snapshot from volume having spaces in name(KVM) ... skipped 'Skip' test_02_snapshot_data_disk (test_snapshots.TestSnapshots) Test Snapshot Data Disk ... skipped 'Skip' test_03_snapshot_detachedDisk (test_snapshots.TestSnapshots) Test snapshot from detached disk ... ok test_04_delete_snapshot (test_snapshots.TestSnapshots) Test Delete Snapshot ... skipped 'Skip' test_07_template_from_snapshot (test_snapshots.TestSnapshots) Create Template from snapshot ... ok ---------------------------------------------------------------------- Ran 7 tests in 529.398s OK (skipped=4) Thanks, Gaurav Aradhye