> On Nov. 8, 2013, 10:11 a.m., Girish Shilamkar wrote: > > Santhosh, > > > > Please update the diff instead of uploading them as different file.
Also the commit header should be "CLOUDSTACK-5099: <Heading>" This will ensure that the jira ticket also gets updated upon merge. - Girish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15341/#review28528 ----------------------------------------------------------- On Nov. 8, 2013, 7:16 a.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15341/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2013, 7:16 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5099 > https://issues.apache.org/jira/browse/CLOUDSTACK-5099 > > > Repository: cloudstack-git > > > Description > ------- > > 1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation > 2. We followed uniform naming convention of Camel casing for classes but here > its not. Changed it. > 3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can > be to local as well remote > > > Diffs > ----- > > > Diff: https://reviews.apache.org/r/15341/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > patch file > > https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke.patch > patchfile > > https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke_1.patch > > > Thanks, > > Santhosh Edukulla > >
