----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15362/ -----------------------------------------------------------
Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description ------- Form fields marked with 'isPassword' are created as input fields with type 'password' so that the value is obfuscated. However, detail view fields (when editing) are not obfuscated. Additionally, if a value is entered and the edit form is submitted, the password is still visible in plain text. This patch fixes the issue by respecting the 'isPassword' attribute on detail view fields. Diffs ----- ui/scripts/ui/widgets/detailView.js 65f71b3 Diff: https://reviews.apache.org/r/15362/diff/ Testing ------- Thanks, Chris Suich