----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15323/#review28641 -----------------------------------------------------------
Ship it! LGTM. will put this in master. Do you need this on 4.2? - Prasanna Santhanam On Nov. 7, 2013, 8:31 p.m., David Grizzanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15323/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2013, 8:31 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-5080 > https://issues.apache.org/jira/browse/CLOUDSTACK-5080 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-5080: Hypervisor Capabilities table missing entry for Simulator > - Added new SQL file to db/setup so that a row gets inserted during simulator > DB setup for a 'Simulator' hypervisor (in hypervisor_capabilities). > - Updated developer/pom.xml to include this new file > > > Diffs > ----- > > developer/pom.xml 0eb18bf > setup/db/hypervisor_capabilities.simulator.sql PRE-CREATION > > Diff: https://reviews.apache.org/r/15323/diff/ > > > Testing > ------- > > Tested on master and 4.2 > > > Thanks, > > David Grizzanti > >