----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15570/#review28954 -----------------------------------------------------------
Ship it! COmmitted to 4.2, 4.3 and master - Girish Shilamkar On Nov. 15, 2013, 7:56 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15570/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2013, 7:56 a.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5180 > https://issues.apache.org/jira/browse/CLOUDSTACK-5180 > > > Repository: cloudstack-git > > > Description > ------- > > Some test cases are failing while uploading the volume just because the time > allowed to upload the volume is less in marvin library. > If timeout is increases, these tests pass. Example - > component.test_stopped_vm.TestUploadAttachVolume.test_upload_attach_volume. > This test case has failed in latest build but had passed earlier build. > > To avoid this inconsistent behaviour, increased the timeout in > "wait_for_upload" function in Volume class in base.py > The test case runs successfully with this change. > > > Diffs > ----- > > tools/marvin/marvin/integration/lib/base.py a3a5f58 > > Diff: https://reviews.apache.org/r/15570/diff/ > > > Testing > ------- > > Tested locally on XenServer basic zone setup. > > client Log: > 2013-11-14 19:43:59,017 - DEBUG - test_upload_attach_volume > (test_stopped_vm.TestUploadAttachVolume) - Uploading the volume: DataDisk > 2013-11-14 19:44:05,299 - DEBUG - test_upload_attach_volume > (test_stopped_vm.TestUploadAttachVolume) - Uploading the volume: DataDisk > 2013-11-14 19:51:05,568 - DEBUG - test_upload_attach_volume > (test_stopped_vm.TestUploadAttachVolume) - Volume: %s uploaded successfully > 2013-11-14 19:51:05,568 - DEBUG - test_upload_attach_volume > (test_stopped_vm.TestUploadAttachVolume) - Deploying VM instance in account: > test-OLJLXM > > Result log: > test_upload_attach_volume (test_stopped_vm.TestUploadAttachVolume) > Test Upload volume and attach to VM in stopped state ... ok > > > ---------------------------------------------------------------------- > Ran 17 tests in 442.869s > > OK (skipped=16) > > > Thanks, > > Gaurav Aradhye > >
