> On Nov. 15, 2013, 1:53 p.m., Murali Reddy wrote: > > Syed I dont think you added 'protocol' to createLoadBalancerRule. There > > should not be 'protocol' in the LoadBalancerContainer?
I actually did add the 'protocol' parameter to createLoadBalancerRule. This maps to `lb_protocol` field in the `load_balancing_rules` table. I added getLbProtocol() to LoabalacnerContainer because I thought that is the right palce as other parameters like algorithm ( getAlgorithm() ) scheme etc are present here. Does this sound correct? - Syed ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15489/#review28968 ----------------------------------------------------------- On Nov. 13, 2013, 6:08 p.m., Syed Ahmed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15489/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2013, 6:08 p.m.) > > > Review request for cloudstack, Alena Prokharchyk and Murali Reddy. > > > Repository: cloudstack-git > > > Description > ------- > > Adding protocol parameter to Loadbalancer Response > > > Diffs > ----- > > api/src/com/cloud/network/rules/LoadBalancer.java e6dadca > api/src/com/cloud/network/rules/LoadBalancerContainer.java 9d5ea59 > api/src/org/apache/cloudstack/api/response/LoadBalancerResponse.java > 0f18097 > > engine/schema/src/org/apache/cloudstack/lb/ApplicationLoadBalancerRuleVO.java > 37a747e > server/src/com/cloud/api/ApiResponseHelper.java 903c485 > > Diff: https://reviews.apache.org/r/15489/diff/ > > > Testing > ------- > > > Thanks, > > Syed Ahmed > >
