----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15825/#review29367 -----------------------------------------------------------
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java <https://reviews.apache.org/r/15825/#comment56565> This should not be a e.printStackTrace. Use s_logger.error(String, Throwable) please so you ensure it ends up in the log indicated by the administrator plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualMachineModelTest.java <https://reviews.apache.org/r/15825/#comment56566> Are you sure you want to catch this exception? Why not let is go through and get reported as a test exception? plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualMachineModelTest.java <https://reviews.apache.org/r/15825/#comment56567> Should this exception be a test failure? plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java <https://reviews.apache.org/r/15825/#comment56568> Test failure instead of catching it? plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java <https://reviews.apache.org/r/15825/#comment56569> same here - Hugo Trippaers On Nov. 24, 2013, 6:59 p.m., Sachchidanand Vaidya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15825/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2013, 6:59 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > The code change adds UnitTest cases for Juniper Contrail Virtual Network(VN) > and Virtual Machine(VM) Model classes. > Only VN & VM creation test cases added. > > > Diffs > ----- > > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java > 7f66a3b > > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java > 32d5d93 > > plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualMachineModelTest.java > PRE-CREATION > > plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java > 0938541 > > Diff: https://reviews.apache.org/r/15825/diff/ > > > Testing > ------- > > Juniper contrail Unit Tests ran successfully as part of package build. > > > Thanks, > > Sachchidanand Vaidya > >
