----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15455/ -----------------------------------------------------------
(Updated Nov. 25, 2013, 2:26 p.m.) Review request for cloudstack and Hugo Trippaers. Changes ------- adding new patch based on Alex changes Repository: cloudstack-git Description ------- Coverity bug #1116754 Resource leak on an exceptional path. The system resource will not be reclaimed and reused, reducing the future availability of the resource. In com.?cloud.?upgrade.?dao.?Upgrade2214to30.?setupPhysicalNetworks(java.?sql.?Connection): Leak of a system resource on an exception path (probably error handling) (CWE-404) Since the file contained the same implementation all over the place - in many different methods - I already updated everything. Diffs ----- engine/schema/src/com/cloud/upgrade/dao/Upgrade2214to30.java 48b83b4 Diff: https://reviews.apache.org/r/15455/diff/ Testing ------- All tests passed during build and I also applied the patch to a different branch, based on Master, and built the project: all passed. File Attachments (updated) ---------------- new_diff https://reviews.apache.org/media/uploaded/files/2013/11/25/aabab4c6-902d-4b37-a60a-7b52b2db13c2__fix_1116754.patch Thanks, Wilder Rodrigues
