----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15508/ -----------------------------------------------------------
(Updated Nov. 25, 2013, 3:32 p.m.) Review request for cloudstack and Hugo Trippaers. Changes ------- Rebasing my patch in order to get the latest changes from Alex Huang Repository: cloudstack-git Description ------- Make sure that if the file does not exist an Exception is thrown and that once it exists it is also closed after the properties are loaded. fix for Coverity bug cv_1125364 Resource leak The system resource will not be reclaimed and reused, reducing the future availability of the resource. In org.?apache.?cloudstack.?network.?contrail.?management.?ManagementNetworkGuru.?configure(java.?lang.?String, java.?util.?Map): Leak of a system resource (CWE-404) Diffs (updated) ----- plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java e86e98a Diff: https://reviews.apache.org/r/15508/diff/ Testing ------- A test branch was created, the patch was applied against the branch and a full build was executed. Everything is working fine. The class changed is tested by MockLocalNfsSecondaryStorageResource. Thanks, Wilder Rodrigues
