Yes, this a generic fix and would apply to all branches.
On Tue, Nov 26, 2013 at 12:19 PM, Santhosh Edukulla < santhosh.eduku...@citrix.com> wrote: > Does this applies to 4,.2 and if possible prior versions as well? > > Santhosh > ________________________________________ > From: Girish Shilamkar [nore...@reviews.apache.org] on behalf of Girish > Shilamkar [gir...@clogeny.com] > Sent: Tuesday, November 26, 2013 1:41 AM > To: Girish Shilamkar; Srikanteswararao Talluri > Cc: Ashutosh Kelkar; cloudstack > Subject: Re: Review Request 15833: CLOUDSTACK-5257: Fixed Network ACL > issue related to Egress traffic > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15833/#review29422 > ----------------------------------------------------------- > > Ship it! > > > Committed to 4.3 and master. > > - Girish Shilamkar > > > On Nov. 25, 2013, 2:37 p.m., Ashutosh Kelkar wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/15833/ > > ----------------------------------------------------------- > > > > (Updated Nov. 25, 2013, 2:37 p.m.) > > > > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao > Talluri. > > > > > > Bugs: CLOUDSTACK-5257 > > https://issues.apache.org/jira/browse/CLOUDSTACK-5257 > > > > > > Repository: cloudstack-git > > > > > > Description > > ------- > > > > The test case was failing due to issue in ACL rule. The ACL rule was > created for TCP protocol and the connection to outside world was checked > using Ping protocol. In this case ICMP protocol should be used in ACL rule > as Ping uses ICMP. > > Also corrected the port numbers and cleaned up code. > > > > > > Diffs > > ----- > > > > test/integration/component/test_vpc_vms_deployment.py baefa55 > > > > Diff: https://reviews.apache.org/r/15833/diff/ > > > > > > Testing > > ------- > > > > Tested locally on XenServer advances setup. > > > > Log: > > test_01_deploy_vms_in_network > (test_vpc_vms_deployment_fixed.TestVMDeployVPC) > > Test deploy VMs in VPC networks ... skipped 'Skip' > > test_02_deploy_vms_delete_network > (test_vpc_vms_deployment_fixed.TestVMDeployVPC) > > Test deploy VMs in VPC networks and delete one of the network ... > skipped 'Skip' > > test_03_deploy_vms_delete_add_network > (test_vpc_vms_deployment_fixed.TestVMDeployVPC) > > Test deploy VMs, delete one of the network and add another one ... > skipped 'Skip' > > test_04_deploy_vms_delete_add_network_noLb > (test_vpc_vms_deployment_fixed.TestVMDeployVPC) > > Test deploy VMs, delete one network without LB and add another one ... > skipped 'Skip' > > test_05_create_network_max_limit > (test_vpc_vms_deployment_fixed.TestVMDeployVPC) > > Test create networks in VPC upto maximum limit for hypervisor ... > skipped 'Skip' > > test_06_delete_network_vm_running > (test_vpc_vms_deployment_fixed.TestVMDeployVPC) > > Test delete network having running instances in VPC ... skipped 'Skip' > > test_07_delete_network_with_rules > (test_vpc_vms_deployment_fixed.TestVMDeployVPC) > > Test delete network that has PF/staticNat/LB rules/Network Acl ... > skipped 'Skip' > > > > ---------------------------------------------------------------------- > > Ran 7 tests in 5.907s > > > > OK (skipped=7) > > > > > > Thanks, > > > > Ashutosh Kelkar > > > > > >
