> On Dec. 30, 2013, 10:33 p.m., Sheng Yang wrote: > > Hi Suresh, > > > > There is no way we can review this since it's not added as diff files. > > > > Please re-do the upload as diff and make sure it in the proper format that > > can be reviewed. "View diff" button should be shown. > > > > Also you'd better rebase the patch to the latest. > > > > Thanks.
I've tried to apply this patch but seems it need to rebase the latest 4.3 branch. - Sheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16276/#review30980 ----------------------------------------------------------- On Dec. 15, 2013, 11:59 p.m., Suresh Balineni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16276/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2013, 11:59 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > Contrail Virtual Router Controller is expecting virtual network name should > have a fully qualified name while creating a Network Policy in the > controller. > > This fix is only applicable to contrail plugin. > > > Diffs > ----- > > > Diff: https://reviews.apache.org/r/16276/diff/ > > > Testing > ------- > > Network Policy creation on Contrail router is verified. > > > File Attachments > ---------------- > > Contrail plugin fixes > > https://reviews.apache.org/media/uploaded/files/2013/12/15/4d041bf8-d5c8-42e0-8a51-e0a9a2cb2f58__vn-fqn.patch > > > Thanks, > > Suresh Balineni > >
